Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-cmd/man: Completely remove --link #10350

Merged
merged 1 commit into from Jan 19, 2021
Merged

dev-cmd/man: Completely remove --link #10350

merged 1 commit into from Jan 19, 2021

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Jan 17, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?
  • This was deprecated in ec75fbc in 2016! 🗝️ 🧓🏻 :dusty_stick:

@BrewTestBot
Copy link
Member

Review period will end on 2021-01-19 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 17, 2021
@issyl0 @dawidd6
dev-cmd/man: Completely remove --link
a0f3545 
- This was deprecated in ec75fbc in 2016!
@issyl0
Copy link
Member Author

issyl0 commented Jan 18, 2021

Ah, yes, the man page code has a man page. ♻️ Thanks @dawidd6!

@MikeMcQuaid
Copy link
Member

Nice catch @issyl0!

@BrewTestBot
Copy link
Member

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 19, 2021
@dawidd6 dawidd6 merged commit 1525350 into Homebrew:master Jan 19, 2021
@dtrodrigues dtrodrigues mentioned this pull request Jan 19, 2021
Merged
8 tasks
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 19, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@dawidd6 dawidd6 dawidd6 approved these changes

@Rylan12 Rylan12 Rylan12 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@issyl0 @BrewTestBot @MikeMcQuaid @dawidd6 @Rylan12